Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAB incompatibility with Velocity ScoreboardAPI and Triton results in missing translations in scoreboard #452

Open
dancebunny98 opened this issue Oct 27, 2024 · 2 comments · May be fixed by #461
Assignees
Labels
module:velocity Related to Velocity on hold Halted and will not be worked on at the moment type:bug Something isn't working as expected
Milestone

Comments

@dancebunny98
Copy link

Describe the bug

Hi @Rexcantor64!

I encountered an issue that arose after introducing the VelocityScoreboardAPI dependency into the TAB plugin.

Before introducing the VelocityScoreboardAPI dependency into the TAB plugin from the author, everything was fine. In new versions, VelocityScoreboardAPI is required, but then translations from triton in the TAB plugin do not work!

How can the bug be reproduced?

Problem:

In previous versions of TAB (before the introduction of VelocityScoreboardAPI), everything worked correctly.
After upgrading to a version that requires VelocityScoreboardAPI, translations from the Triton plugin to the scoreboard stopped working.

What was expected:

Translations from Triton should be displayed in the scoreboard as they were before.
What is actually happening:
Untranslated strings are displayed in the scoreboard.

Configuration:

TAB plugin (version 5.0.7) is installed on Velocity.
TAB-Bridge plugin is installed on Spigot.
Triton plugin is installed on Velocity.

Expected behaviour

https://github.com/NEZNAMY/TAB-Bridge/releases and VelocityScoreboardAPI
5.0.7 works with triton as it does not use https://github.com/NEZNAMY/VelocityScoreboardAPI
Without VelocityScoreboardAPI TAB does not work!
Triton translations in the plugin do not work with VelocityScoreboardAPI and TAB!

Which Spigot fork are you using?

Other (specify below)

What's your server version?

git-Leaf-"83c2468" (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: 83c2468 on ver/1.20.4)

Which proxy are you using?

Velocity

What's your proxy version?

Velocity 3.3.0-SNAPSHOT (git-0cd069ec-b431)

What's the MC version of your client?

1.20.4

What's the Triton version you're using?

4.0

Additional Information

https://discord.com/channels/395565283047374850/1014321555427315743/1299799021837226025

@dancebunny98 dancebunny98 added triage Hasn't been manually reviewed type:bug Something isn't working as expected labels Oct 27, 2024
@diogotcorreia diogotcorreia added module:velocity Related to Velocity and removed triage Hasn't been manually reviewed labels Oct 28, 2024
@diogotcorreia diogotcorreia added this to the 4.0.0 milestone Oct 28, 2024
@diogotcorreia
Copy link
Member

Unfortunately this seems to be unfixable given how Triton currently handles packets. Once Triton uses PacketEvents this will likely be fixed as well.

@diogotcorreia diogotcorreia added the on hold Halted and will not be worked on at the moment label Nov 13, 2024
@diogotcorreia
Copy link
Member

Work in #461 will fix this issue

@diogotcorreia diogotcorreia linked a pull request Nov 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:velocity Related to Velocity on hold Halted and will not be worked on at the moment type:bug Something isn't working as expected
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants