Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EcoEnchants translation support (not lore) #290

Open
roggy666 opened this issue Apr 6, 2023 · 2 comments
Open

Add EcoEnchants translation support (not lore) #290

roggy666 opened this issue Apr 6, 2023 · 2 comments
Assignees
Labels
help wanted module:spigot Related to Spigot/PaperMC type:feature A new functionality
Milestone

Comments

@roggy666
Copy link

roggy666 commented Apr 6, 2023

Describe the Feature

I really need the ability to translate enchantments, in my case this is EcoEnchants, where enchantments are not lore

@roggy666 roggy666 added triage Hasn't been manually reviewed type:feature A new functionality labels Apr 6, 2023
@diogotcorreia diogotcorreia added module:spigot Related to Spigot/PaperMC and removed triage Hasn't been manually reviewed labels Apr 6, 2023
@diogotcorreia diogotcorreia added this to the 3.8.4 milestone Apr 6, 2023
@diogotcorreia diogotcorreia modified the milestones: 3.8.4, 3.8.5 Apr 28, 2023
@diogotcorreia
Copy link
Member

This is going to be pretty difficult to implement: EcoEnchants is hooking into the netty pipeline as well, but it's doing so after ProtocolLib, which means Triton can't detect its lores.
I'll have to investigate if there's any workaround.
Additionally, Triton v3 would completely obliterate some markers eco puts into the lores (i.e. §z). This won't be an issue on Triton v4.

Here's some implementation details that I found while investigating:

I'll move this to the v4 backlog, but even then this won't be easy and might require some custom code specifically for eco.

@diogotcorreia diogotcorreia modified the milestones: 3.8.5, 4.0.0 May 21, 2023
@diogotcorreia diogotcorreia moved this to Todo in Triton May 21, 2023
@mani1232
Copy link

Lore too need support, %triton_lang% work but showing in default lang, [lang][/lang] dont work

@diogotcorreia diogotcorreia modified the milestones: 4.0.0, 4.1.0 Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted module:spigot Related to Spigot/PaperMC type:feature A new functionality
Projects
Status: Todo
Development

No branches or pull requests

3 participants