Minor cleanups on varbinary to varchar coercion #24274
Merged
+20
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
changed the title
Praveen2112
force-pushed
the
praveen/fix_coercion
branch
from
48d8464
to
823bb55
Compare
|
First two commits LGTM. Please drop the third one - I want to add it with tests |
In case of Unpartitioned hive parquet table, the coercion is not as per Hive's implementation
Praveen2112
force-pushed
the
praveen/fix_coercion
branch
from
1d99a90
to
bb94330
Compare
Praveen2112
requested review from
wendigo,
raunaqmorarka,
krvikash and
marcinsbd
wendigo
approved these changes
Nov 28, 2024
krvikash
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor cleanups like removing assertion for un-partitioned parquet tables as we don't support in the reading them like Hive does and unifying the coercion code for non-orc tables.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: