Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'late unwraps' in DSL #933

Closed
squell opened this issue Dec 16, 2024 · 0 comments · Fixed by #934
Closed

Remove 'late unwraps' in DSL #933

squell opened this issue Dec 16, 2024 · 0 comments · Fixed by #934
Labels
C-checker Permission checking logic C-parser Parser/AST suggestion

Comments

@squell
Copy link
Member

squell commented Dec 16, 2024

As @japaric once noted, the current Defaults DSL constructs a "dynamically typed" object which involves some unwrap()-like behaviour in a late stage (those will always succeed, but there's no static guarantee for them).

@squell squell added C-parser Parser/AST C-checker Permission checking logic suggestion labels Dec 16, 2024
@squell squell mentioned this issue Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-checker Permission checking logic C-parser Parser/AST suggestion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant