diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 40a4e2c..dd394d9 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -16,11 +16,11 @@ jobs: fail-fast: false matrix: include: - - ruby: 2.7.7 + - ruby: 2.7.8 puppet: 7 fixtures: .fixtures.yml allow_failure: false - - ruby: 3.2.2 + - ruby: 3.2.3 puppet: 8 fixtures: .fixtures.yml allow_failure: false @@ -48,13 +48,13 @@ jobs: fail-fast: false matrix: set: - - "el7" - "el8" - "el9" - - "debian-10" - "debian-11" + - "debian-12" - "ubuntu-2004" - "ubuntu-2204" + - "ubuntu-2404" puppet: - "puppet7" - "puppet8" diff --git a/.rubocop.yml b/.rubocop.yml index 3b93cd8..9f6b1ec 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -59,7 +59,15 @@ Style/TernaryParentheses: Style/TrailingCommaInArguments: Description: Prefer always trailing comma on multiline argument lists. This makes diffs, and re-ordering nicer. - EnforcedStyleForMultiline: comma + EnforcedStyleForMultiline: consistent_comma +Style/TrailingCommaInArrayLiteral: + Description: Prefer always trailing comma on multiline argument lists. This makes + diffs, and re-ordering nicer. + EnforcedStyleForMultiline: consistent_comma +Style/TrailingCommaInHashLiteral: + Description: Prefer always trailing comma on multiline argument lists. This makes + diffs, and re-ordering nicer. + EnforcedStyleForMultiline: consistent_comma Style/SymbolArray: Description: Using percent style obscures symbolic intent of array's contents. EnforcedStyle: brackets diff --git a/.sync.yml b/.sync.yml index eb96a10..76fd03e 100644 --- a/.sync.yml +++ b/.sync.yml @@ -2,13 +2,14 @@ .github/workflows/ci.yaml: acceptance_matrix: set: - - el7 + - ---el7 - el8 - el9 - - debian-10 - debian-11 + - debian-12 - ubuntu-2004 - ubuntu-2204 + - ubuntu-2404 puppet: - puppet7 - puppet8 diff --git a/Gemfile b/Gemfile index 4bc7150..300688d 100644 --- a/Gemfile +++ b/Gemfile @@ -17,7 +17,7 @@ ruby_version_segments = Gem::Version.new(RUBY_VERSION.dup).segments minor_version = ruby_version_segments[0..1].join('.') group :development do - gem "voxpupuli-test", '5.4.1', require: false + gem "voxpupuli-test", '7.0.0', require: false gem "faraday", '~> 1.0', require: false gem "github_changelog_generator", require: false gem "puppet-blacksmith", require: false @@ -29,8 +29,8 @@ group :system_tests do gem "beaker-pe", require: false gem "beaker-hostgenerator" gem "beaker-rspec" - gem "beaker-docker" - gem "beaker-puppet" + gem "beaker-docker", git: 'https://github.com/treydock/beaker-docker.git', branch: 'amazon-2023' + gem "beaker-puppet", git: 'https://github.com/puppetlabs/beaker-puppet.git', ref: '6063d22b6c4449df795731f5853c3c75241240c4' gem "beaker-puppet_install_helper", require: false gem "beaker-module_install_helper", require: false end diff --git a/metadata.json b/metadata.json index 308bba8..04baff5 100644 --- a/metadata.json +++ b/metadata.json @@ -21,17 +21,10 @@ { "operatingsystem": "RedHat", "operatingsystemrelease": [ - "7", "8", "9" ] }, - { - "operatingsystem": "CentOS", - "operatingsystemrelease": [ - "7" - ] - }, { "operatingsystem": "Rocky", "operatingsystemrelease": [ @@ -49,15 +42,16 @@ { "operatingsystem": "Debian", "operatingsystemrelease": [ - "10", - "11" + "11", + "12" ] }, { "operatingsystem": "Ubuntu", "operatingsystemrelease": [ "20.04", - "22.04" + "22.04", + "24.04" ] } ], @@ -72,5 +66,5 @@ ], "pdk-version": "2.7.1", "template-url": "https://github.com/treydock/pdk-templates.git#master", - "template-ref": "heads/master-0-g70732db" + "template-ref": "heads/master-0-gd2de99e" } diff --git a/spec/acceptance/nodesets/debian-10.yml b/spec/acceptance/nodesets/debian-12.yml similarity index 85% rename from spec/acceptance/nodesets/debian-10.yml rename to spec/acceptance/nodesets/debian-12.yml index cfd3be2..648a143 100644 --- a/spec/acceptance/nodesets/debian-10.yml +++ b/spec/acceptance/nodesets/debian-12.yml @@ -1,10 +1,10 @@ HOSTS: - debian10: + debian12: roles: - agent - platform: debian-10-amd64 + platform: debian-12-amd64 hypervisor: docker - image: debian:10 + image: debian:12 docker_preserve_image: true docker_cmd: - '/sbin/init' @@ -18,7 +18,7 @@ HOSTS: - LANG=en_US.UTF-8 - LANGUAGE=en_US.UTF-8 - LC_ALL=en_US.UTF-8 - docker_container_name: 'munge-debian10' + docker_container_name: 'munge-debian12' CONFIG: log_level: debug type: foss diff --git a/spec/acceptance/nodesets/el8.yml b/spec/acceptance/nodesets/el8.yml index eeba76a..e3c951f 100644 --- a/spec/acceptance/nodesets/el8.yml +++ b/spec/acceptance/nodesets/el8.yml @@ -1,10 +1,10 @@ HOSTS: - rocky-8: + el8: roles: - agent platform: el-8-x86_64 hypervisor: docker - image: almalinux:8 + image: rockylinux:8 docker_preserve_image: true docker_cmd: - '/usr/sbin/init' diff --git a/spec/acceptance/nodesets/el9.yml b/spec/acceptance/nodesets/el9.yml index bcef932..aef6a6a 100644 --- a/spec/acceptance/nodesets/el9.yml +++ b/spec/acceptance/nodesets/el9.yml @@ -1,10 +1,10 @@ HOSTS: - almalinux-9: + el9: roles: - agent platform: el-9-x86_64 hypervisor: docker - image: almalinux:9 + image: rockylinux:9 docker_preserve_image: true docker_cmd: - '/usr/sbin/init' diff --git a/spec/acceptance/nodesets/ubuntu-2404.yml b/spec/acceptance/nodesets/ubuntu-2404.yml new file mode 100644 index 0000000..b34764b --- /dev/null +++ b/spec/acceptance/nodesets/ubuntu-2404.yml @@ -0,0 +1,25 @@ +HOSTS: + ubuntu2404: + roles: + - agent + platform: ubuntu-24.04-amd64 + hypervisor : docker + image: ubuntu:24.04 + docker_preserve_image: true + docker_cmd: '["/sbin/init"]' + docker_image_commands: + - "rm -f /etc/dpkg/dpkg.cfg.d/excludes" + - 'apt-get install -y wget net-tools iproute2 locales apt-transport-https ca-certificates' + - 'locale-gen en_US.UTF-8' + docker_env: + - LANG=en_US.UTF-8 + - LANGUAGE=en_US.UTF-8 + - LC_ALL=en_US.UTF-8 + docker_container_name: 'munge-ubuntu2404' +CONFIG: + log_level: debug + type: foss +ssh: + password: root + auth_methods: ["password"] + diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 7272754..c854cc5 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -13,12 +13,12 @@ default_facts = { puppetversion: Puppet.version, - facterversion: Facter.version + facterversion: Facter.version, } default_fact_files = [ File.expand_path(File.join(File.dirname(__FILE__), 'default_facts.yml')), - File.expand_path(File.join(File.dirname(__FILE__), 'default_module_facts.yml')) + File.expand_path(File.join(File.dirname(__FILE__), 'default_module_facts.yml')), ] default_fact_files.each do |f| diff --git a/spec/spec_helper_acceptance.rb b/spec/spec_helper_acceptance.rb index 8867310..3523614 100644 --- a/spec/spec_helper_acceptance.rb +++ b/spec/spec_helper_acceptance.rb @@ -9,7 +9,8 @@ Dir["#{dir}/acceptance/shared_examples/**/*.rb"].sort.each { |f| require f } require 'spec_helper_acceptance_local' if File.file?(File.join(File.dirname(__FILE__), 'spec_helper_acceptance_local.rb')) -run_puppet_install_helper +run_puppet_install_helper unless ['debian-12', 'ubuntu-2404'].include?(ENV['BEAKER_set']) +on hosts, 'apt install -y puppet-agent' if ['debian-12', 'ubuntu-2404'].include?(ENV['BEAKER_set']) install_module_on(hosts) install_module_dependencies_on(hosts)