Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keycloak_flow_execution updates config on every puppet run #338

Open
misspenalty opened this issue Dec 11, 2024 · 0 comments
Open

keycloak_flow_execution updates config on every puppet run #338

misspenalty opened this issue Dec 11, 2024 · 0 comments

Comments

@misspenalty
Copy link

misspenalty commented Dec 11, 2024

I have defined a keycloak_flow_execution for several realms with the following code:

  keycloak_flow_execution { $flow_name:
    ensure       => 'present',
    display_name => 'SMS Authentication',
    alias        => "SMS ${realm_code}",
    configurable => true,
    config       => {
      length     => '6',
      ttl        => '300',
      sender     => $sender,
      username   => $sms_api_username,
      password   => $sms_api_password,
      url        => $sms_api_url,
      timeout    => '10',
      simulation => false,
    },
    priority     => $flow_priority,
    requirement  => 'REQUIRED',
  }

However, it is clear from the puppet logs as well as from keycloak admin event logs that the config is changed on every puppet run (where it calls the authentication/config/ endpoint and sends the defined config as JSON). The API is called even when I have not changed the values of the config in puppet or in Keycloak. There does not seem to be a check in https://github.com/treydock/puppet-module-keycloak/blob/149c85b15b70fb51d5630054fd00c2ce92525462/lib/puppet/provider/keycloak_flow_execution/kcadm.rb that would compare the old settings with the new settings and ignoring the update when there are no actual changes. Would it be possible to include such a check, so that there is not an admin event on every puppet run? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant