Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

named.test.js unittest failing #24

Open
AaronNGray opened this issue Jul 30, 2017 · 5 comments
Open

named.test.js unittest failing #24

AaronNGray opened this issue Jul 30, 2017 · 5 comments

Comments

@AaronNGray
Copy link
Contributor

AaronNGray commented Jul 30, 2017

Run on Debian 8.5 with 'dig' available.

~/GitHub/node-named/test$ nodeunit named.test.js

named.test.js
Error: bind EINVAL 0.0.0.0:1153
    at Object.exports._errnoException (util.js:1050:11)
    at exports._exceptionWithHostPort (util.js:1073:20)
    at _handle.lookup (dgram.js:215:18)
    at _combinedTickCallback (internal/process/next_tick.js:83:11)
    at process._tickDomainCallback (internal/process/next_tick.js:128:9)

FAILURES: Undone tests (or their setups/teardowns): 
- listen and close (port only)

To fix this, make sure all tests call test.done()
@AaronNGray
Copy link
Contributor Author

Failing with same results on Windows 10 with 'dig' command available.

@trevoro
Copy link
Owner

trevoro commented Jul 30, 2017

Hey Aaron,

Thats quite strange; it seems as though something else is listening on port 1153 as well.
Can you check to see if that's the case?
Otherwise I'm not seeing any failures here using node 8.

What version of node and npm are you using on these platforms?

@trevoro
Copy link
Owner

trevoro commented Jul 30, 2017

Oh I had something bad in my repo; will take a look! Great find.

@AaronNGray
Copy link
Contributor Author

AaronNGray commented Jul 30, 2017

solved !

clue is here :- #20 (comment)

https://github.com/trevoro/node-named/blob/master/lib/server.js#L53
https://github.com/trevoro/node-named/blob/master/lib/server.js#L74

need to test address type ip4/ip6 and act accordingly.

@gtato
Copy link

gtato commented Feb 13, 2018

So is there any good reason why this change is not pushed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants