Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python Wrapper: Fix reader iteration #7139

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Python Wrapper: Fix reader iteration #7139

merged 1 commit into from
Dec 10, 2023

Conversation

N-o-Z
Copy link
Member

@N-o-Z N-o-Z commented Dec 10, 2023

Closes #7138

@N-o-Z N-o-Z added exclude-changelog PR description should not be included in next release changelog python-wrapper labels Dec 10, 2023
@N-o-Z N-o-Z requested review from nopcoder and guy-har December 10, 2023 11:27
@N-o-Z N-o-Z self-assigned this Dec 10, 2023
guy-har
guy-har approved these changes Dec 10, 2023
View reviewed changes
clients/python-wrapper/tests/integration/test_object.py
@@ -306,3 +306,26 @@ def test_readline_partial_line_buffer(setup_repo):
assert read == expected

assert reader.read() == ""


def test_write_read_csv(setup_repo):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@N-o-Z N-o-Z enabled auto-merge (squash) December 10, 2023 11:38
@N-o-Z N-o-Z merged commit 99f5d06 into master Dec 10, 2023
38 checks passed
@N-o-Z N-o-Z deleted the fix/python-wrapper-stop-iteration-on-reader-7138 branch December 10, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guy-har guy-har guy-har approved these changes

@nopcoder nopcoder Awaiting requested review from nopcoder

Assignees

@N-o-Z N-o-Z

Labels
exclude-changelog PR description should not be included in next release changelog python-wrapper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Python Wrapper: No iteration stop on reader
2 participants
@N-o-Z @guy-har