Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forget password cleanup #6604

Closed
wants to merge 7 commits into from
Closed

Forget password cleanup #6604

wants to merge 7 commits into from

Conversation

idanovo
Copy link
Contributor

@idanovo idanovo commented Sep 14, 2023

No description provided.

@idanovo idanovo added area/API Improvements or additions to the API include-changelog PR description should be included in next release changelog v1.0.0-blocker Issues that should be closed before going out with v1.0.0 labels Sep 14, 2023
@idanovo idanovo linked an issue Sep 14, 2023 that may be closed by this pull request
API cleanup: update/forgot password removal #6532
Closed
@github-actions
Copy link

github-actions bot commented Sep 14, 2023 •
edited
Loading

🎊 PR Preview ebfdbd2 has been successfully built and deployed to https://treeverse-lakeFS-preview-pr-6604.surge.sh

🕐 Build time: 0.027s

🤖 By surge-preview

@idanovo idanovo requested a review from nopcoder September 14, 2023 09:26
nopcoder
nopcoder suggested changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check and remove the email.Emailer related implementaion and configuration.

@idanovo idanovo requested a review from nopcoder September 14, 2023 12:25
nopcoder
nopcoder suggested changes Sep 17, 2023
View reviewed changes
Copy link
Contributor

@nopcoder nopcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break the current behaviour as it will introduce invite users even if you are not using external API.

@idanovo idanovo self-assigned this Sep 18, 2023
@nopcoder
Copy link
Contributor

@idanovo can I close this one?

@nopcoder
Copy link
Contributor

nopcoder commented Nov 2, 2023

Closing this one - reopen if needed, I think work on the invite user should be done in order to remove the code.

@nopcoder nopcoder closed this Nov 2, 2023
@idanovo idanovo deleted the 6532-forget-password-cleanup branch January 21, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nopcoder nopcoder nopcoder requested changes

Assignees

@idanovo idanovo

Labels
area/API Improvements or additions to the API include-changelog PR description should be included in next release changelog v1.0.0-blocker Issues that should be closed before going out with v1.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API cleanup: update/forgot password removal
2 participants
@idanovo @nopcoder