Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System stats, docker stats, bulk metrics, fixes, etc #65

Open
wants to merge 45 commits into
base: master
Choose a base branch
from
Open

System stats, docker stats, bulk metrics, fixes, etc #65

wants to merge 45 commits into from

Conversation

jsiembida
Copy link
Contributor

@jsiembida jsiembida commented Jun 27, 2017

This change adds:

  • Collection of system statistics
  • Collection of docker container stats

Improvements:

  • Bulk data transfers between components as well as in influx protocol.
  • Fixes carbon client blocking startup while trying to reconnect
  • Fixes StatsD @ Py3

@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage decreased (-2.7%) to 44.644% when pulling 15e3565 on jsiembida:docker-stats-support into a779aeb on trbs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.7%) to 44.644% when pulling 15e3565 on jsiembida:docker-stats-support into a779aeb on trbs:master.

@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage decreased (-2.8%) to 44.564% when pulling 7595351 on jsiembida:docker-stats-support into a779aeb on trbs:master.

@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage decreased (-3.09%) to 44.305% when pulling 24c3c74 on jsiembida:docker-stats-support into a779aeb on trbs:master.

@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage decreased (-3.3%) to 44.133% when pulling da09fb7 on jsiembida:docker-stats-support into a779aeb on trbs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.3%) to 44.133% when pulling da09fb7 on jsiembida:docker-stats-support into a779aeb on trbs:master.

@coveralls
Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage decreased (-2.9%) to 44.514% when pulling ba54cb3 on jsiembida:docker-stats-support into a779aeb on trbs:master.

@coveralls
Copy link

coveralls commented Jun 29, 2017

Coverage Status

Coverage decreased (-3.2%) to 44.236% when pulling 2c72bc8 on jsiembida:docker-stats-support into a779aeb on trbs:master.

@trbs
Copy link
Owner

trbs commented Jun 29, 2017

Thanks for all your work !

Can I ask to make separate PR's for the individual improvements ? (Docker, Influxdb, etc)
That will make it a lot easier to get them merged.

Thanks !

@jsiembida
Copy link
Contributor Author

jsiembida commented Jun 29, 2017

It may be a bit difficult for me to separate those out. This comes as one stream of work since I was working on everything at the same time really. Also, some things are inherently convoluted.

I am about to introduce one compatibility breaking change, I really wanna drop statsd_legacy_namespace and just use the new naming scheme. Do you mind?

EDIT: Actually, ignore that, I think I can work around the legacy mode.

@coveralls
Copy link

coveralls commented Jun 29, 2017

Coverage Status

Coverage decreased (-3.06%) to 44.332% when pulling a75c845 on jsiembida:docker-stats-support into a779aeb on trbs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.06%) to 44.332% when pulling a75c845 on jsiembida:docker-stats-support into a779aeb on trbs:master.

@coveralls
Copy link

coveralls commented Jun 29, 2017

Coverage Status

Coverage decreased (-3.2%) to 44.224% when pulling d2a45b0 on jsiembida:docker-stats-support into a779aeb on trbs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.2%) to 44.224% when pulling d2a45b0 on jsiembida:docker-stats-support into a779aeb on trbs:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.6%) to 43.803% when pulling 7c1896b on jsiembida:docker-stats-support into a779aeb on trbs:master.

2 similar comments
@coveralls
Copy link

coveralls commented Jul 1, 2017

Coverage Status

Coverage decreased (-3.6%) to 43.803% when pulling 7c1896b on jsiembida:docker-stats-support into a779aeb on trbs:master.

@coveralls
Copy link

coveralls commented Jul 1, 2017

Coverage Status

Coverage decreased (-3.6%) to 43.803% when pulling 7c1896b on jsiembida:docker-stats-support into a779aeb on trbs:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants