Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Tree of Tabs on Middle-Click #217

Open
funnyflowerpot opened this issue Jun 23, 2017 · 4 comments
Open

Close Tree of Tabs on Middle-Click #217

funnyflowerpot opened this issue Jun 23, 2017 · 4 comments

Comments

@funnyflowerpot
Copy link

funnyflowerpot commented Jun 23, 2017

I would love to have an option to quickly close a tab and all its children (i.e. a tree with the selected tab as root). This function is already present in the context menu of a tab as "Close Tree", but closing a tree on e.g. middle-click would be more convenient.

In that sense, the extension's settings could hold an entry named "On middle-click on tab" and a drop-down menu with options "Close tab", "Close tree", "Flip tabs", "Do nothing", etc. This might streamline the settings page.

I was using Tree Style Tabs before and I'm so much happier with Tab Tree. This is the only tiny feature I'm missing. Thanks for making this great extension!

@mathiasose
Copy link

mathiasose commented Jul 18, 2017

the extension's settings could hold an entry named "On middle-click on tab" and a drop-down menu with options "Close tab", "Close tree", "Flip tabs", "Do nothing", etc.

I also wish for a setting like this.
I'm using my laptop touchpad at the moment and keep hitting the "middle click" area when I intend to hit the "left click" area, resulting in me closing the tab I meant to change to.
Just one of those minor annoyances that a setting like this could prevent with a "do nothing" option.

@akrusemark
Copy link

I have a similar idea, to collapse the tree of tabs by double-clicking. It'd be nice just to have more options for both middle click and for double click.

traxium added a commit that referenced this issue Aug 13, 2017
@funnyflowerpot
Copy link
Author

By coincidence I've seen, that this issue was addressed yesterday and a new release is already available. I've installed and tested and can confirm: Works like a charm! Wonderful!

Thank you very much for taking time for that issue so quickly! I'll convert all my Firefoxes to Tab Tree now.

@funnyflowerpot
Copy link
Author

However, it seems like the parent tab won't get closed, if the last child is the very last tab of all tabs in the tab bar.

Maybe it's safer to g.removeTab(tab) instead of g.removeTab(g.tabs[tPos]) in const closeTabAndAllChildren = function (tab) { /*...*/ }? (Sorry, can't test myself right now.)

traxium added a commit that referenced this issue Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants