Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No linting errors when there should be #3

Open
ghost opened this issue Oct 13, 2017 · 5 comments
Open

No linting errors when there should be #3

ghost opened this issue Oct 13, 2017 · 5 comments

Comments

@ghost
Copy link

ghost commented Oct 13, 2017

linter-solium 0.0.4 (Enabled)
linter 2.2.0 (Enabled)
I have run npm update solium -g, and solium --init in my project's root directory.
Atom 1.21.1

E.g. function pay_and_donate... (not camel case) isn't highlighted as a linting error. No errors in Atom's console.

@Sjors
Copy link

Sjors commented Nov 13, 2017

Are you seeing the bug related icons at all in the bottom (with zeros)?
schermafbeelding 2017-11-13 om 19 55 58

I recently forgot to run solium --init; it would be nice if the plugin complained if that's missing, so I don't start thinking I'm just really good :-)

@ghost
Copy link
Author

ghost commented Nov 14, 2017

They're all zero, even after running solium --init in the same directory as the contract.
screen shot 2017-11-14 at 17 35 57

@travs
Copy link
Owner

travs commented Dec 21, 2017

@Sjors

it would be nice if the plugin complained if that's missing, so I don't start thinking I'm just really good :-)

thanks for the suggestion! Opened #4

@willnwhite
What OS are you running on? Seems like the helper function for finding the rc file is not working properly, and it may have to do with the filesystem or something

@ghost
Copy link
Author

ghost commented Dec 21, 2017

I was on Mac OS X Yosemite, now on macOS High Sierra and it's the same. I do remember it working previously, perhaps before v0.0.4.

@michaeldzjap
Copy link

I'm having the same problem. Also on macOS High Sierra. I ran solium --init, but

import './SomeToken.sol'

doesn't flag my single quotes as an error (left the default quotes rule on double in .soliumrc.json).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants