This repository has been archived by the owner on Jul 26, 2022. It is now read-only.
Replace mem data store with file data store #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm sorry for the delay but I've been busy with completely unrelated work. Now, thank you for putting the effort into this. However, this is not a new idea to me and I actually put the work before but didn't push because I concluded it was a bad idea to store such sensitive information. Let's look at #14 first and then come back at this. |
|
@pires Ah, I understand your security concern. How do you deal with this issue then, especially for CLI tools that pull from Nexus during local dev workflows or CI/CD automation? Do you have to make sure everyone logs in via the browser each time a new Pod launches? |
Use a file-based data store to enable persisting the credential store beyond server restarts.
|
Hi @pires. This is a ping for my previous comment. Do you have the problem I mentioned in my earlier comment? How do you address it? |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14
Use a file-based data store to enable persisting the credential store beyond server restarts.
The in-memory store has been replaced completely because it is causes this bug. In fact, the file-based store behaves the same way as the in-mem if run in a container without a volume attached to persist the store. However, if a persistent volume is used then auth tokens continue to work after restart and before a fresh oauth flow.