Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Docx parser #351

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Fix for Docx parser #351

merged 1 commit into from
Aug 6, 2024

Conversation

foteinigk
Copy link
Contributor

@foteinigk foteinigk commented Aug 6, 2024 •
edited
Loading

Problem and/or solution

How to test

If last_element is None, an exception is thrown when we try to access last_elemetns.contents[0] and template can not be compiled.

Reviewer checklist

Code:

  • Change is covered by unit-tests
  • Code is well documented, well styled and is following best practices
  • Performance issues have been taken under consideration
  • Errors and other edge-cases are handled properly

PR:

  • Problem and/or solution are well-explained
  • Commits have been squashed so that each one has a clear purpose
  • Commits have a proper commit message according to TEM

@foteinigk foteinigk merged commit c1b0d48 into devel Aug 6, 2024
4 checks passed
@foteinigk foteinigk deleted the dockx_fix branch August 6, 2024 09:08
@txsentinel txsentinel mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pliakisnick pliakisnick pliakisnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@foteinigk @pliakisnick