iterate-over-empty-map.yaml false positives

[GrosQuildu]

The iterate-over-empty-map.yaml should exclude from results cases when the map is passed to a function - the function probably will write to it. We can use cross-function analysis from pro engine to check if there really are the writes.

package main

import "fmt"

func Do(y map[string]int64) int64 {
	y["a"] = 1
	y["b"] = 2
	return 3
}

func main() {
	fmt.Println("Hello, 世界")
	x := map[string]int64{}
	Do(x)
	fmt.Printf("%d\n", len(x))
	for k, v := range x {
		fmt.Println(k, v)
	}
}

[paleboot]

Hi! Thanks for all these rules you folks came up with.

We encountered another false positive as well for this rule:

package main

import "strings"

var aMap = map[string]struct{}{
    "prefix1": {},
    "prefix2": {},
}

func iter2(s string) {
     for key := range aMap {
           if strings.HasPrefix(key, s) {
                return true
           }
     }
     return false
}

Playground:

[GrosQuildu]

This one is because of #36
Waiting for upstream fix. Thanks for reporting the issue anyway!