Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve non_local_effect_before_error_return diagnostic messages #1009

Closed
smoelius opened this issue Jan 9, 2024 · 2 comments
Closed

Improve non_local_effect_before_error_return diagnostic messages #1009

smoelius opened this issue Jan 9, 2024 · 2 comments

Comments

@smoelius
Copy link
Collaborator

smoelius commented Jan 9, 2024

@fcasal writes:

Do you think it would be possible to know and mention the origin of the issue for these expansion cases? e.g., instead of saying “call with mutable reference before error return”, say “call FUNC with mutable reference before error return in FUNC for trait …“. This way you can start looking into the concrete function causing the warning.
@smoelius
Copy link
Collaborator Author

smoelius commented Jan 9, 2024

Related #929

@smoelius
Copy link
Collaborator Author

Fixed by #1019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@smoelius