chore: add v3 instructions #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmengin
approved these changes
Oct 17, 2024
nmengin
added
area/documentation
mloiseleur
reviewed
Oct 17, 2024
mloiseleur
reviewed
Oct 17, 2024
kevinpollet
requested changes
Oct 18, 2024
sheddy-traefik
force-pushed
the
chore/update-readme
branch
2 times, most recently
from
01332c8
to
034d603
Compare
|
@kevinpollet all suggestions have been implemented |
emilevauge
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Thanks @sheddy-traefik :)
I made a few comments/suggestions
|
Updated with your suggestions @emilevauge 👍 |
emilevauge
requested changes
Oct 21, 2024
|
all good now @emilevauge |
|
@emilevauge @kevinpollet can we merge? |
kevinpollet
requested changes
Oct 23, 2024
rtribotte
reviewed
Oct 24, 2024
kevinpollet
reviewed
Oct 24, 2024
kevinpollet
reviewed
Oct 24, 2024
sheddy-traefik
force-pushed
the
chore/update-readme
branch
from
432885d
to
cae5e2e
Compare
Co-authored-by: Emile Vauge <[email protected]> Co-authored-by: Michel Loiseleur <[email protected]>
sheddy-traefik
force-pushed
the
chore/update-readme
branch
from
cae5e2e
to
6d7b6e7
Compare
|
All good now @kevinpollet need your approval so we can merge |
kevinpollet
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add instructions for using Traefik v3 docker image
closes: #71