Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error page code 404 can not preview on CMS #905

Conversation

pack254
Copy link
Contributor

@pack254 pack254 commented Oct 31, 2024

Description

this PR is fixed the issue #904

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • [ ] This change is covered with tests (or tests aren't necessary for this change)
  • [ ] Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@pack254 pack254 force-pushed the bugfix/error-page-404-can-not-cms-preview branch from ec76d40 to 18580f8 Compare October 31, 2024 22:33
@pack254 pack254 force-pushed the bugfix/error-page-404-can-not-cms-preview branch from 18580f8 to 00a1537 Compare October 31, 2024 22:34
@tractorcow
Copy link
Collaborator

Thank you @pack254 appreciate your contribution. Can anyone merge this once the build passes?

@pack254 pack254 changed the title fix error page code 404 can not CMS preview fix error page code 404 can not preview on CMS Nov 4, 2024
@tractorcow tractorcow merged commit 19d9b1c into tractorcow-farm:7 Dec 3, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants