Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG Fix issue with Security link being wrong #691

Open
wants to merge 1 commit into
base: 5.0
Choose a base branch
from
Open

BUG Fix issue with Security link being wrong #691

wants to merge 1 commit into from

Conversation

tractorcow
Copy link
Collaborator

fixes #689

@purplespider can you please help test this with your project? It should resolve the security url issue.

@tractorcow tractorcow mentioned this pull request Mar 23, 2021
Open
@purplespider
Copy link

Ace! Can confirm this fixes #689 in my project.

However, just to confirm, LocaleMenu.ss links still won't work on Security pages until #458 is also resolved.

@tractorcow
Copy link
Collaborator Author

hm yes I think you are right.

@tractorcow
Copy link
Collaborator Author

I have re-reviewed #688 to add some suggestion for getting that fix over the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Frontend locale menu doesn't work on login form (Security)
2 participants
@tractorcow @purplespider