expected *mut u8, found *mut i8

[adam-blip]

Describe the bug

To Reproduce
Steps to reproduce the behavior:

1. git clone https://github.com/Tracel-AI/burn
2. cargo run checks-all
   see error.log
   for detail

Expected behavior
compiling runs without error

Desktop (please complete the following information):

• OS: ChromeOS latest / Debian container linux penguin 6.6.50-05090-g02ec56928355 refactor: create tape only during backprop #1 SMP PREEMPT Fri, 8 Nov 2024 00:13:13 +0000 aarch64 GNU/Linux
• Browser chrome Version 130.0.6723.126 (Official Build) (64-Bit)

Additional context
tensor multiplication in 'getting started' example runs just fine

[adam-blip]

using 0.15. release zip instead of git clone works fine

[laggui]

@syl20bnr looks like a cubecl HIP issue:

error[E0308]: mismatched types
   --> /home/user/.cargo/git/checkouts/cubecl-aa41a28b39b598f9/1c4e003/crates/cubecl-hip/src/compute/server.rs:357:18
    |
357 |             vec![cpp_std_option_cstr.as_ptr(), include_option_cstr.as_ptr()];
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `*const i8`, found `*const u8`
    |
    = note: expected raw pointer `*const i8`
               found raw pointer `*const u8`

error[E0308]: mismatched types
    --> /home/user/.cargo/git/checkouts/cubecl-aa41a28b39b598f9/1c4e003/crates/cubecl-hip/src/compute/server.rs:361:85
     |
361  | ...   cubecl_hip_sys::hiprtcCompileProgram(program, options.len() as i32, options_pt...
     |       ------------------------------------                                ^^^^^^^^^^^ expected `*mut *const u8`, found `*mut *const i8`
     |       |
     |       arguments to this function are incorrect
     |
     = note: expected raw pointer `*mut *const u8`
                found raw pointer `*mut *const i8`
note: function defined here
    --> /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cubecl-hip-sys-0.0.7/src/bindings/bindings_622.rs:1407:12
     |
1407 |     pub fn hiprtcCompileProgram(
     |            ^^^^^^^^^^^^^^^^^^^^

error[E0308]: mismatched types
    --> /home/user/.cargo/git/checkouts/cubecl-aa41a28b39b598f9/1c4e003/crates/cubecl-hip/src/compute/server.rs:371:75
     |
371  | ... = cubecl_hip_sys::hiprtcGetProgramLog(program, log_buffer.as_mut_ptr());
     |       -----------------------------------          ^^^^^^^^^^^^^^^^^^^^^^^ expected `*mut u8`, found `*mut i8`
     |       |
     |       arguments to this function are incorrect
     |
     = note: expected raw pointer `*mut u8`
                found raw pointer `*mut i8`
note: function defined here
    --> /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cubecl-hip-sys-0.0.7/src/bindings/bindings_622.rs:1438:12
     |
1438 |     pub fn hiprtcGetProgramLog(
     |            ^^^^^^^^^^^^^^^^^^^

error[E0308]: mismatched types
   --> /home/user/.cargo/git/checkouts/cubecl-aa41a28b39b598f9/1c4e003/crates/cubecl-hip/src/compute/server.rs:376:42
    |
376 |                 let log = CStr::from_ptr(log_buffer.as_ptr());
    |                           -------------- ^^^^^^^^^^^^^^^^^^^ expected `*const u8`, found `*const i8`
    |                           |
    |                           arguments to this function are incorrect
    |
    = note: expected raw pointer `*const u8`
               found raw pointer `*const i8`
note: associated function defined here
   --> /rustc/90b35a6239c3d8bdabc530a6a0816f7ff89a0aaf/library/core/src/ffi/c_str.rs:277:25

error[E0308]: mismatched types
    --> /home/user/.cargo/git/checkouts/cubecl-aa41a28b39b598f9/1c4e003/crates/cubecl-hip/src/compute/server.rs:405:65
     |
405  | ...atus = cubecl_hip_sys::hiprtcGetCode(program, code.as_mut_ptr());
     |           -----------------------------          ^^^^^^^^^^^^^^^^^ expected `*mut u8`, found `*mut i8`
     |           |
     |           arguments to this function are incorrect
     |
     = note: expected raw pointer `*mut u8`
                found raw pointer `*mut i8`
note: function defined here
    --> /home/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cubecl-hip-sys-0.0.7/src/bindings/bindings_622.rs:1449:12
     |
1449 |     pub fn hiprtcGetCode(prog: hiprtcProgram, code: *mut ::std::os::raw::c_cha...
     |            ^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0308`.
error: could not compile `cubecl-hip` (lib) due to 5 previous errors
warning: build failed, waiting for other jobs to finish...

/edit:

I didn't even notice the cargo run-checks-all command🤦 my brain mapped it to the usual ./run-checks all that is used everywhere

[syl20bnr]

@adam-blip What is this command cargo run checks-all ? I don't think we documented this command anywhere in the repository. Try cargo xtask validate or ./run-checks at the root of the repository. See CONTRIBUTING.md for more info.

[adam-blip]

@syl20bnr looks like a cubecl HIP issue:

/edit:

I didn't even notice the cargo run-checks-all command🤦 my brain mapped it to the usual ./run-checks all that is used everywhere

Same here... dunno where that came from.
error stays the same with cargo xtask validate with git clone burn

[nmgray]

I am getting the same cubecl issue when using git clone. Is this perhaps something related to the target architecture (I am running an stable-aarch64-unknown-linux-gnu)? Does this have to be run in nightly?

[kitterion]

I believe I fixed this in tracel-ai/cubecl#413, though I didn't know this bug existed 😅

It didn't make it into version 0.4.0 of cubecl unfortunately, so you might need to wait until the next version is released (or use a patched version of cubecl for now).