Refactor and Update the tcti-x-helper #2899
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
wxleong
force-pushed
the
fix-tcti-helper
branch
7 times, most recently
from
6a34882 to
96e137c
Compare
wxleong
force-pushed
the
fix-tcti-helper
branch
3 times, most recently
from
4f76b2c to
9682496
Compare
- Moved common transmit/receive FIFO protocol code to tcti-helper-common. - Refined the FIFO protocol implementation. - Updated unit test implementation so that changes to the FIFO protocol no longer require modifications to all dependent unit tests. Signed-off-by: wenxin.leong <[email protected]>
wxleong
force-pushed
the
fix-tcti-helper
branch
from
9682496 to
f170d3b
Compare
| LOG_ERROR ("Failed to send the command"); | ||
| return rc; | ||
| } | ||
|
|
There was a problem hiding this comment.
Here we should check for STS_VALID | EXPECT, not ?
| LOG_ERROR ("Failed to send the command"); | ||
| return rc; | ||
| } | ||
|
|
There was a problem hiding this comment.
Here we should again check for STS_VALID | EXPECT
| } | ||
|
|
||
| /* Await TPM readiness */ | ||
| expected_status_bits = TCTI_HELPER_COMMON_TPM_STS_VALID | TCTI_HELPER_COMMON_TPM_STS_DATA_EXPECT; |
There was a problem hiding this comment.
Here, the expected status should be STS_VALID | !EXPECT
I wonder why this still works ?
| return TSS2_RC_SUCCESS; | ||
| } | ||
|
|
||
| TSS2_RC Tcti_Helper_Common_Transmit (TCTI_HELPER_COMMON_CONTEXT *ctx, size_t size, const uint8_t *cmd_buf) |
There was a problem hiding this comment.
We are missing the retry-logic in this function.
It always goes directly to "return error"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2891, resolves #2620