You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The build system is currently using the git diff to figure out if the docker file or an m4 module changed and if so is triggering that build to occur. The problem with this, is any change to a module means that everything gets rebuilt which can cause issues in non-modified containers because of dependency changes in their package managers. To solve this, an easy way would be to capture the true dependencies or changes of the docker file. I propose two solutions:
look at the docker.m4 file for the container and see what "includes" it uses. Then if either the file or included modules are changed, allow the build to go through. This has the drawbacks of needing to look through the include with a grep or something.
The other approach would be to checkout the master branch and type make and record the sha256sum of the built docker files, then checkout the PR and run make again and see what changed based on the sha256sums. This has the drawback on publish where their is no pr event but rather a push event how to define that delta. Approach 1 is probably the right solution.
The text was updated successfully, but these errors were encountered:
The build system is currently using the git diff to figure out if the docker file or an m4 module changed and if so is triggering that build to occur. The problem with this, is any change to a module means that everything gets rebuilt which can cause issues in non-modified containers because of dependency changes in their package managers. To solve this, an easy way would be to capture the true dependencies or changes of the docker file. I propose two solutions:
The text was updated successfully, but these errors were encountered: