Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make build system smarter by figuring out true changes #70

Open
williamcroberts opened this issue Jul 12, 2022 · 0 comments
Open

make build system smarter by figuring out true changes #70

williamcroberts opened this issue Jul 12, 2022 · 0 comments

Comments

@williamcroberts
Copy link
Member

The build system is currently using the git diff to figure out if the docker file or an m4 module changed and if so is triggering that build to occur. The problem with this, is any change to a module means that everything gets rebuilt which can cause issues in non-modified containers because of dependency changes in their package managers. To solve this, an easy way would be to capture the true dependencies or changes of the docker file. I propose two solutions:

  1. look at the docker.m4 file for the container and see what "includes" it uses. Then if either the file or included modules are changed, allow the build to go through. This has the drawbacks of needing to look through the include with a grep or something.
  2. The other approach would be to checkout the master branch and type make and record the sha256sum of the built docker files, then checkout the PR and run make again and see what changed based on the sha256sums. This has the drawback on publish where their is no pr event but rather a push event how to define that delta. Approach 1 is probably the right solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant