build: Fix undefined references when using slibtool #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salahcoronya
force-pushed
the
slibtool
branch
from
8c87d70 to
e79db5a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #88 +/- ##
=======================================
Coverage 78.17% 78.17%
=======================================
Files 17 17
Lines 2667 2667
=======================================
Hits 2085 2085
Misses 582 582 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Christopher Byrne <[email protected]>
salahcoronya
force-pushed
the
slibtool
branch
from
e79db5a to
8e892b7
Compare
|
Could you give some more information and rational for this change ? |
|
In GNU libtool, -no-undefined does nothing. See https://wiki.gentoo.org/wiki/Slibtool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.