Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is a "step"? #36

Closed
simonbyrne opened this issue Feb 6, 2019 · 2 comments · Fixed by #60
Closed

What is a "step"? #36

simonbyrne opened this issue Feb 6, 2019 · 2 comments · Fixed by #60

Comments

@simonbyrne
Copy link

The sampler prints out info like "0.19 s/step". I assume that's per MH step, not per leapfrog step? It would be useful to be more precise.

@tpapp
Copy link
Owner

tpapp commented Feb 6, 2019

Good question. It is the time spent building each tree (there are no MH steps in HMC). Perhaps it would be more informative to display

  • avg time / leapfrog step
  • avg tree depth or size
  • avg time / tree

This should be addressed by #30.

tpapp added a commit that referenced this issue Aug 19, 2019
@tpapp tpapp closed this as completed in #60 Aug 19, 2019
tpapp added a commit that referenced this issue Aug 19, 2019
@tpapp
Copy link
Owner

tpapp commented Aug 19, 2019

I clarified this in the docs after the API reorg, feeling that this is the best I can do without being too verbose. If you have a suggestion, please feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants