Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: add one zone per room #6

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JuliusR
Copy link

@JuliusR JuliusR commented Apr 4, 2021

I just experimented with the scripting feature. When writing scripts, it is useful to have defined zones.

As a disadvantage of these zone definitions, the map.json grows quite a bit because these are 44 additional layers, and each layer has a large data array. I did not notice any loading-performance problems, though.

The layer names and zone-property values are incomplete: Some rooms are labelled room_unknown_[A-O] because I could not find the correct labels. If you consider to accept this PR then I am happy to fix the labelling. Is there any source where I can find the correct labels?

@tovogt
Copy link
Owner

tovogt commented Apr 6, 2021

It's great that you looked into the scripting feature!

For the room numbers, I don't even know whether the current numbers are correct. The only way to be sure would be to go to the physical building and look at the signs next to each door. I doubt that they are perfectly sequential, some might be missing etc. Maybe you know someone who is visiting Telegrafenberg from time to time and can have a look?

For the zone definitions, I would suggest to add only those rooms for which we already have some scripted functionality because that clutters the list of layers in Tiled quite a bit. Do you already have a particular functionality in mind that you would like to implement?

@JuliusR
Copy link
Author

JuliusR commented Apr 12, 2021

For the room numbers, I don't even know whether the current numbers are correct.

Oh, I did not see that coming.

Maybe you know someone who is visiting Telegrafenberg from time to time and can have a look?

I have been told that the room numbers of "Erde" are correct. I will ask about the other rooms, too.

For the zone definitions, I would suggest to add only those rooms for which we already have some scripted functionality because that clutters the list of layers in Tiled quite a bit.

Sounds reasonable. Feel free to close this PR. If I get any updates, I will open a new PR that corrects and completes the current room-number labeling.

Do you already have a particular functionality in mind that you would like to implement?

No, I do not have a particular functionality in mind. I experimented with small easter eggs that add more liveliness to the map, and I also imagined a small team-building game in the style of a cooperative multiplayer adventure (like a virtual escape game, but with a positive atmosphere instead of a threatening atmosphere). However, all that was just learning and playing around. I do not have the plan to implement anything complex, but I considered my zone definitions to be a useful contribution.

@tovogt
Copy link
Owner

tovogt commented Apr 12, 2021

Thanks for checking the room numbers!

I suggest to leave this PR open until we have some concrete functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants