Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we add noUncheckedSideEffectImports? #18

Open
wparsons-heins-globality opened this issue Oct 4, 2024 · 2 comments
Open

Can we add noUncheckedSideEffectImports? #18

wparsons-heins-globality opened this issue Oct 4, 2024 · 2 comments

Comments

@wparsons-heins-globality
Copy link

Are you guys okay with adding this even though it's only just come out?

It's saved me a tonne of time when porting an ES5 repo to ES6, but obviously is going to require downstream to update to the latest typescript.
@mattpocock
Copy link
Collaborator

https://github.com/total-typescript/tsconfig/blob/main/bundler/dom.json#L14

@wparsons-heins-globality
Copy link
Author

Sorry I meant --noUncheckedSideEffectImports. I'll update the PR title.

@wparsons-heins-globality wparsons-heins-globality changed the title Can we add noUncheckedIndexedAccess? Can we add --noUncheckedSideEffectImports? Oct 7, 2024
@wparsons-heins-globality wparsons-heins-globality changed the title Can we add --noUncheckedSideEffectImports? Can we add noUncheckedSideEffectImports? Oct 7, 2024
@mattpocock mattpocock reopened this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattpocock @wparsons-heins-globality