Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use coverage upload token #399

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

da2ce7
Copy link
Contributor

@da2ce7 da2ce7 commented Sep 6, 2023

No description provided.

Copy link
Member

@josecelano josecelano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @da2ce7, It looks good. I've seen you have created a repository token. Just a reminder for other contributors: in general, we prefer a more restricted scope for secrets, like creating a new environment for codecov and linking the secret to that environment. In this case, I suppose the actions for the token are very limited and with a repository secret we can generate the coverage report everywhere.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #399 (5bea92d) into develop (710548b) will increase coverage by 0.21%.
Report is 2 commits behind head on develop.
The diff coverage is 62.50%.

@@             Coverage Diff             @@
##           develop     #399      +/-   ##
===========================================
+ Coverage    83.98%   84.19%   +0.21%     
===========================================
  Files          102      102              
  Lines         7182     7208      +26     
===========================================
+ Hits          6032     6069      +37     
+ Misses        1150     1139      -11     
Files Changed Coverage Δ
contrib/bencode/src/reference/decode.rs 96.20% <ø> (ø)
src/servers/apis/mod.rs 100.00% <ø> (ø)
src/servers/apis/v1/middlewares/auth.rs 96.42% <ø> (ø)
src/tracker/databases/driver.rs 87.50% <ø> (ø)
src/tracker/mod.rs 96.23% <ø> (ø)
packages/configuration/src/lib.rs 81.25% <54.54%> (-0.74%) ⬇️
src/lib.rs 62.12% <55.55%> (ø)
src/bootstrap/config.rs 100.00% <100.00%> (+100.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@da2ce7
Copy link
Contributor Author

da2ce7 commented Sep 6, 2023

ACK 5bea92d

@da2ce7 da2ce7 merged commit 9ebe477 into torrust:develop Sep 6, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants