Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not able to open additional URLs with the same torbrowser instance #245

Open
duritong opened this issue Sep 23, 2016 · 2 comments · May be fixed by #395
Open

Not able to open additional URLs with the same torbrowser instance #245

duritong opened this issue Sep 23, 2016 · 2 comments · May be fixed by #395

Comments

@duritong
Copy link

duritong commented Sep 23, 2016 •
edited
Loading

Running torbrowser-launcher 0.2.6 I'm not able to open new tabs/windows through executing torbrowser-launcher again. TBB always tells me that there is already another instance running:

$ rpm -qi torbrowser-launcher 
Name        : torbrowser-launcher
Version     : 0.2.6

Running it the first time works fine:

$ cd ~/.local/share/torbrowser/tbb/x86_64/tor-browser_en-US/ && ./start-tor-browser.desktop https://github.com/micahflee/torbrowser-launcher
Launching './Browser/start-tor-browser --detach https://github.com/micahflee/torbrowser-launcher'...

This opens a torbrowser window opening this projects repository.

Doing it a second time (while the other one is still running, looks exactly the same, BUT TBB complains:

Tor Browser is already running, but is not responding. To open a new window, you must first close the existing Tor Browser process, or restart your system.

This makes it impossible to use TBB/torbrowser-launcher as an opener for URLs in other programs.
@u451f
Copy link
Contributor

u451f commented Jan 27, 2017

Confirmed. See https://trac.torproject.org/projects/tor/ticket/14977 for upstream ticket.

hefee added a commit to hefee/torbrowser-launcher that referenced this issue Mar 23, 2019
@hefee
Open additional URLs with the same TorBrowser instance
1f9d403 
When we looked at the history of issues about opening links with TorBrowser, we
found torproject#103 where initially the feature to open links from other applications
was added. Then some months later, the feature was removed again, as it was not
working because of torproject#157 and torproject#175. The issues was back then (~4years ago), that
when users had a normal Firefox running, urls got opened in the normal firefox
insead of TorBrowser. That was because TorBrowser had the --no-remote flag set
deep down in their code.
In the meanwhile TorBrowser removed the explicit --no-remote flag, so we are
able to use --allow-remote again.
On top of that there is another issue when we want open urls with TorBrowser:
If the LOGNAME is the same as the LOGNAME of the opened firefox, urls are still
opened in the open firefox. But if we set the LOGNAME envrionment variable
explicitly, we can make sure, that the url opens in the TorBrowser instead of
a running Firefox.

Should fix: torproject#245, torproject#259, torproject#380
@hefee hefee linked a pull request Mar 23, 2019 that will close this issue
Open
@sporksmith
Copy link

Any update on this issue? This is a blocker to being able to usefully set TBB as the default browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Open additional URLs with the same TorBrowser instance hefee/torbrowser-launcher
3 participants
@duritong @sporksmith @u451f