Ability to specify multiple file types in testFilePattern section. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current karma-sonarqube-unit-reporter plugin supports only one input file type e.g. spec.js or spec.ts, after this change, user can pass array of input file types.
|
Hello, that's a good improvement (i need the same). But i suggest use RegExp instead of array, because it's more powerfull (filter is not only on endsWith) and maybe more efficient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current project has a requirement to have spec files in both
spec.jsandspec.tsformat. But current plugin doesn't have option to specify multiple file types and raising exceptions.Now with this commit,
testFilePatterncan be specified as single pattern astestFilePattern:'.spec.js'or array of patternstestFilePattern: ['.spec.js', '.spec.ts'].