Create Version of Plugin Without Font Awesome Dependency #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Font Awesome Dependency. Update Leaflet.js and jQuery in example. Remove Bootstrap in example. Add css rule so "legend" element shows above map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits represent a proposed branch of this project that removes the Font Awesome dependency.
The plugin uses an
imgelement, which is provided in thedistfolder, but is set in the constructor options. This allows the user to decide where to store the referencedimgelement.Changes:
-- Use
imgelement instead ofielement.-- Remove Font Awesome Dependency.
-- Update Leaflet.js and jQuery in example.
-- Remove Bootstrap in example.
-- Add css rule so "legend" element shows above map.