Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domed roof not respecting min_height #204

Open
RedAuburn opened this issue Dec 31, 2022 · 1 comment
Open

domed roof not respecting min_height #204

RedAuburn opened this issue Dec 31, 2022 · 1 comment
Assignees
Labels

Comments

@RedAuburn
Copy link

RedAuburn commented Dec 31, 2022

Screenshot 2022-12-31 at 02 17 55

https://www.openstreetmap.org/way/43649840

for some reason, the domed roof is ignoring min_height.

The building should look like this:
Greenwich_Foot_Tunnel_Entrance,Greenwich_Pier-geograph org uk-_1944751
(from commons/geograph)

@tordanik
Copy link
Owner

Ok, there are two issues with OSM2World's behavior here:

First, this code for guessing the height of a domed roof in the absence of roof:height has no upper limit. It should clearly be limited to be at most the total height of the building part.

Second, OSM2World could probably just assume that roof:height equals the total building part height if the part is tagged building:part=roof.

Marking this as a bug. In the meantime, explicitly tagging roof:height=5 m would avoid the issue (if you're looking for a workaround).

@tordanik tordanik self-assigned this Dec 31, 2022
@tordanik tordanik added the bug label Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants