-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'Additional source production - today' sensor #31
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
Hmm, i did a little research, and it looks like this data is missing in the python-e3dc get_db_data function.
Found this open issue there: fsantini/python-e3dc#44 According to the RSCP tags this could be in DB_PM_0_POWER or DB_PM_1_POWER, but i have no clue how this fits together. There's also something about these PowerMeters in issue #23. If I can provide additional information/data, please let me know. |
@VDRainer The power meters are as far as I know for consumption like heat pumps, the sources have their own entries. To get a better picture, could you please update to 2.1 and create a diagnostics dump that you upload to https://kurzer.link/e3dcrscp ? I'm not sure if it contains everything, but it'll give me a first impression how your unit looks like? |
Hi @torbennehmer , thanks for looking at this. |
@VDRainer Thanks for the upload, it arrived perfectly and already gave me some insights. Please let me push out 2.1 first, I'm just checking compatibility against current HASS (mainly the Python 3.11 change). As soon that's done, I'll skim a bit deeper through the data our your unit and the tag listings. I'm fairly sure that we can get this to work, might need some configuration UI though, not sure yet. |
Running 3.1.1 on HA 2023.8.0b2 without issues at the moment. |
Hello!
|
Please use the template sensor to build combined sensors, for now I'll not add these to the integration, as it'll open the door for other combinations as well if we start here. |
@VDRainer Could you please check if the new cumulative sensors added with 3.4 serve your purpose for your additional productions? If yes, please drop me one final diagnostics dump, I'd like to deprecate the old sensor if possible and need more input for that. |
@torbennehmer , dump config_entry-e3dc_rscp-9d15c0ae403f5f6ebc480fee63b38ad0.json.txt uploaded. Not a big Problem, but i also need template sensors in HA. |
Get the same result with negative values for my additional sources. Any solution to fix this? |
I make a helper to convert the negative value to positive for my additional Solar inverter. It should work as workaround. I think the initial request comes from external energy usage from a heat pump and this is negative? A Solar inverter is normally a positive value ;-) but no problem. For this reason I make additional helper to add normal and additional Solar inverter to combined value. |
@icke-pp Could you attach a diagnostic dump built with the current release for me to look into your data? If possible, please take it at a time when your additional power meters read values, not when they are 0 (that's important). Thanks! |
Had to wait for the weekend. 😄 |
@VDRainer, @ekorn, @icke-pp: Thanks for the dumps, that cleared it up. |
@VDRainer, @ekorn, @icke-pp: I've published 3.6.0-beta.1 as a testing release. It contains the fix for PM_TYPE_ADDITIONAL powermeters. It would be great if you could give it a test run. Be aware, though, that this release contains a larger refactoring of the e3dy python interface layer. To my tests it works well, but it hasn't seen much testing yet beyond that. Please report anything as a new issue (unless it's about our powermeters). Independent of all these sidenotes, I would be very grateful if all three of you could attach another diagnostics dump with 3.6.0-beta.1 or newer (if you decide to wait for the stable release) to this issue. I don't have an E3DC with additional sensors, so this information helps me a lot to get a better understanding how the units in the wild react. |
Hi @torbennehmer , thanks for your effort. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
If you have add the E3DC "Can-Bus Repeater" into your E3DC and connect it with your external inverter you see it automatically as "ext. Quelle" on your E3DC display. If this works you see the external "additional inverter power" we mean here in this issue. If you did not add this Can-Bus Repeater you are unable to see any external inverter power. |
@torbennehmer I'm sorry that I cannot sent you an diagnostic dump because I get an error message all the time if I try to generate it (Webseite nicht verfügbar). |
This comment was marked as off-topic.
This comment was marked as off-topic.
@1tomtom Please create an individual issue here, adding all the debugging info. Thanks! |
I cannot reproduce this on my end with current 3.6 beta, I need stacktrace informations from the log here. If it is against 3.5.x or earlier, please test against 3.6, the diagnostics code has changed since then. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Please head for https://github.com/fsantini/python-e3dc if using the pye3dc lib directly, this project is centered around the HA integration of pye3dc. Thanks! |
I'm just committing a fix, I broke a case statement which affected PM autodetection. Check 3.6.0 beta 2 once it is released. |
|
I'm closing this issue for now, as it seems to be fixed. If the measurements are still broken for you, please reopen a new bug with a diagnostic dump. If the diag dump still fails, then, too, open a new one with the debug log attached to the issue, so that I can fix that one. Thanks all for your help! |
@torbennehmer , but wasn't this FR not about an 'Additional source production - today' sensor? 🤔 |
@VDRainer Ah yes, of course. We got so sidetrackted with these other problems. I'll pick this up these days (I'm a bit busy right now) and sort it out. You'll get taken care of if possible of course! |
Checklist
Is your feature request related to a problem? Please describe.
Enabled the 'Additional source production' sensor, but missing the 'Additional source production - today'.
Describe the solution you'd like
Add the 'Additional source production - today' sensor like the 'Solar production - today'
Describe alternatives you've considered
This could be made with the Integration - Riemann sum integral and Utility Meter in HA, but why not add it like the other 'today' senors?
Additional context
Great work btw.
I use fsantini's lib (did a few trial and error hacks to publish the values to mqtt) for years now.
Thanks for this, so much easier!
The text was updated successfully, but these errors were encountered: