Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"POST /terms" error message when "legacyId" in not unique #22

Open
maxceem opened this issue Apr 26, 2020 · 0 comments
Open

"POST /terms" error message when "legacyId" in not unique #22

maxceem opened this issue Apr 26, 2020 · 0 comments

Comments

@maxceem
Copy link
Contributor

maxceem commented Apr 26, 2020

At the moment if we try to create a new "TermsOfUse" record and send legacyId which is already in use, server would return error with status 500:

{
    "message": "Internal server error"
}

It's hard to understand what is wrong with request from this error message.

It would be better to return some particular error message with status 400, like:

{
    "message": "TermsOfUse with such 'legacyId' already exists. It should be unique."
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant