Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block code background color #126

Open
adtoolsdev opened this issue Jun 8, 2024 · 2 comments
Open

Block code background color #126

adtoolsdev opened this issue Jun 8, 2024 · 2 comments
Labels
complex The issue is complex to resolve or implement enhancement New feature or request

Comments

@adtoolsdev
Copy link

adtoolsdev commented Jun 8, 2024

I typed

import pandas as pd

issue_toolstackfolio
Apparently the code block does not change the background color after being added. Is it possible to implement this feature?

@toolstack toolstack added the enhancement New feature or request label Jun 8, 2024
@toolstack toolstack added this to the Next release milestone Jun 8, 2024
@toolstack
Copy link
Owner

Possible yes.

I had noticed it and thought it weird that inline code changed the background colour but code blocks didn't. Will make the change for the next release.

@toolstack
Copy link
Owner

I took a look and now know why it wasn't implemented before, it's more complex than it first appears.

Because the code block uses tags in the GTK SourceView widget, if you change the background colour, it only changes for the text as displayed, which means if you have a multi-line code block that isn't fully justified, you get a saw tooth effect at the end of the lines.

Will need to look into this some more and see if the background of the entire line can be changed easily.

@toolstack toolstack modified the milestones: Next release, Future release Jun 9, 2024
@toolstack toolstack added the complex The issue is complex to resolve or implement label Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complex The issue is complex to resolve or implement enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants