Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tag value's size configurable #36

Open
nhatthm opened this issue Jan 7, 2015 · 2 comments
Open

Make tag value's size configurable #36

nhatthm opened this issue Jan 7, 2015 · 2 comments

Comments

@nhatthm
Copy link

nhatthm commented Jan 7, 2015

Hi, I have some features that need tags to be bigger than 65 bytes. Currently I forked your code and make it 255, then compiled and reinstalled

Can we make that value configurable? And what are the cons for that? From my side, I see only UDP buffer sizes will be impacted, it needs to be monitored and increased to prevent losing packets.

@tony2001
Copy link
Owner

tony2001 commented Jan 7, 2015

You've just increased memory usage 4x for every tag.
That might affect overall memory usage quite seriuosly when there are millions of timers with tags.
I'll think about a way of making it configurable, but I can't think of any real need to send values this big. These are just tags, more or less unique identifiers, you really don't need to put whole poems in there.
Let me guess, you just use Namespace+Class name+Method as your tags, right? :)

@nhatthm
Copy link
Author

nhatthm commented Jan 7, 2015

actually, i'm trying to track 404 and 503, and would like to add referrer and user-agent to understand why user reached that situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants