-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add implementation of INY and DEY opcode #21
Conversation
On the face it, this looks good to me. Assuming the tests pass? |
I did run nargo test on both inx and iny but the helpers directory code throws errors which #22 is supposed to fix.
and I am successfully getting a trace. |
Hi . @goblinoats I have checked and tested the code and and both opcodes are working once #22 gets merged.
This has been corrected by @matthieuauger in his PR #24 . |
Oops @Prabhat1308 just noticed we developed the same DEY opcode, I pushed it this morning following implementation of DEX yesterday evening. My bad I should have created the related issue |
There's a small conflict for your PRs @Prabhat1308 following #22 but once you resolve that and double check it's all good I will merge them in. |
@goblinoats I have resolved the merge conflicts. |
@Prabhat1308 in order to keep git history clean you should rebase on main instead of merging main in your branch. I can help on this if you need to |
@matthieuauger sure , would like some help |
Signed-off-by: Prabhat1308 <[email protected]> change opcode in tests Signed-off-by: Prabhat1308 <[email protected]>
Signed-off-by: Prabhat1308 <[email protected]> changes to dey fix Signed-off-by: Prabhat1308 <[email protected]>
👍 |
feat: Add implementation of INY and DEY opcode changes to dey fix Signed-off-by: Prabhat1308 <[email protected]> feat: add opcodes clc cld cli clv Signed-off-by: Prabhat1308 <[email protected]> reolve merge conflicts Signed-off-by: Prabhat1308 <[email protected]> fix: merge issues Signed-off-by: Prabhat1308 <[email protected]>
fixes the issue #20 and #25
checks out the INY and DEY opcode from #6 master instruction tracker