Skip to content
This repository has been archived by the owner on Nov 11, 2023. It is now read-only.

File path ignores defined in .rubocop.yml are not respected #43

Open
timkrins opened this issue Sep 8, 2017 · 1 comment
Open

File path ignores defined in .rubocop.yml are not respected #43

timkrins opened this issue Sep 8, 2017 · 1 comment

Comments

@timkrins
Copy link

timkrins commented Sep 8, 2017

When autocorrect is being performed, I am receiving Rubocop notices on files in directories which I have specifically ignored in the .rubocop.yml file.

It might be here, due to the way this package runs the autocorrect with a temporary file

tempFilePath = @makeTempFile("rubocop.rb")
fs.writeFileSync(tempFilePath, buffer.getText())

and, as the path is different, Rubocop does not understand that this temporary file should be ignored.

I will think more about fixing this and if I get time submit a pull request.

@tomoya
Copy link
Owner

tomoya commented Sep 8, 2017

Hi @timkrins, I got it.

If you submit a pull-request, I will check it immediately. Thank you,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants