Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log should never include password #19

Open
freimer opened this issue Feb 28, 2023 · 0 comments · May be fixed by #20
Open

Log should never include password #19

freimer opened this issue Feb 28, 2023 · 0 comments · May be fixed by #20

Comments

@freimer
Copy link

freimer commented Feb 28, 2023

nla/ntlm.go line 413 (currently) outputs password. This should never happen, regardless of log level. If you must output something, output a hash of the password that can be checked, not the actual password.
@freimer freimer linked a pull request Feb 28, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Log SHA256 hash of password instead of password freimer/grdp
1 participant
@freimer