Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xochitl package should restart the xochitl.service on postremove #912

Open
Havner opened this issue Sep 6, 2024 · 2 comments
Open

xochitl package should restart the xochitl.service on postremove #912

Havner opened this issue Sep 6, 2024 · 2 comments
Labels
bug Something isn't working packages Add or improve packages of the repository

Comments

@Havner
Copy link

Havner commented Sep 6, 2024

Describe the issue

When removing the xochitl package the service that is running is run through /opt/bin/xochitl which means it's probably run with a rm2fb client (xochitl.service.d/toltec-wrapper.conf).

An issue arose with it when removing toltec completely (toltecctl uninstall) that xochitl held /opt and it couldn't be unmounted (device is busy).

Uninstalling xochitl package should restart the service on postremove so it's running through /usr/bin/xochitl and it releases any held files/whatever from /opt.

Discussed on discord. Hopefully it's clear and simple enough for me not to put "steps to reproduce".

@Havner Havner added bug Something isn't working packages Add or improve packages of the repository labels Sep 6, 2024
@Havner
Copy link
Author

Havner commented Sep 7, 2024

One thing to consider is that maybe it should be restarted only if it is running and/or enabled? I don't exactly know all the use cases here, whether it is a valid use case to have xochitl disabled when doing toltecctl uninstall and actually not wanting it to run afterwards? I presume it's like 1% of use cases but I know too little about the assumptions toltec makes here to know for sure.

Just adding this comment as a thought to consider. In any case if the service is actually running it should be restarted.

@Eeems
Copy link
Member

Eeems commented Sep 7, 2024

toltecctl uninstall will enable xochitl after finishing removing everything:

systemctl enable xochitl

#692 this PR makes the output from this even better for end users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working packages Add or improve packages of the repository
Projects
None yet
Development

No branches or pull requests

2 participants