Custom image prefixes #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of other Docker image locations.
|
What was your reason for needing to use a different registry for toolchain images? I'm not certain we'd really want to support that, and instead require users to use the official ones we publish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi thanks for Toltec and the great tooling around the reMarkable.
I'm not sure if this PR would be helpful, but I wanted to submit it in case it was. I've been building locally and finding a need to point to my own container registry while doing so.
This PR let's a user pass in an
--image-prefixlike so:toltecmk --image-prefix "ghcr.io/chriscohoat/", which let's a user build from an alternate location. It defaults toghcr.io/toltec-dev/, if not provided.If this isn't desired no worries, happy to close it out. Thanks again!