Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to set ssl client_key / client_cert ? #173

Open
grosser opened this issue Jun 4, 2019 · 6 comments
Open

how to set ssl client_key / client_cert ? #173

grosser opened this issue Jun 4, 2019 · 6 comments
Assignees

Comments

@grosser
Copy link

grosser commented Jun 4, 2019

#84 is kinda similar, more docs in the readme would be nice

@grosser
Copy link
Author

grosser commented Jun 4, 2019

/cc @lenage because that ssl PR looks neat!

@julik julik self-assigned this Aug 6, 2019
@julik
Copy link
Collaborator

julik commented Aug 6, 2019

@grosser Thanks for the issue, apologies I am finding it so late, I wasn't monitoring the patron repo as eagerly as I should have. I'll have a look, seems like we... don't have that option yet.

@julik
Copy link
Collaborator

julik commented Aug 6, 2019

Yes the PR mentioned does contain the options. Maybe it could be handy to rename the accessor methods for it to indicate that it is not the self-signed server certificate/CA but instead the client SSL cert. @grosser I can offer to finish the PR if you really need the functionality or you can pick it up if you have some spare time, it looks practically done

@grosser
Copy link
Author

grosser commented Aug 7, 2019

I'm not blocked for now, I was researching alternatives for our current net-http-persistent setup and this looked promising, I just could not get ssl to work :)

@julik
Copy link
Collaborator

julik commented Aug 7, 2019

Gotcha. For your use case: you need client certificates, a custom CA store, or both?

@grosser
Copy link
Author

grosser commented Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants