Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18Uruguay] New updated tile sheet from designer #11314

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

patrikolesen
Copy link
Contributor

New updated tile sheet from the Designer

Before clicking "Create"

  • Branch is derived from the latest master

  • Add the pins or archive_alpha_games label if this change will break existing games
    I cannot add pins but this change might break existing games

  • Code passes linter with docker compose exec rack rubocop -a

  • Tests pass cleanly with docker compose exec rack rake

Implementation Notes

Explanation of Change

Screenshots

Any Assumptions / Hacks

@ollybh ollybh added pins PR that will require some games to be pinned 18Uruguay labels Nov 6, 2024
@ollybh ollybh merged commit 5080278 into tobymao:master Nov 10, 2024
1 check passed
@ollybh
Copy link
Collaborator

ollybh commented Nov 16, 2024

@patrikolesen Four 18Uruguay games are broken after deploying this pull request: game IDs 176676, 177067, 177447 and 178966. They fail with errors Blocking step Deliver goods cannot process action or Blocking step Destination Bonus cannot process action. Pinning them to the previously deployed version doesn't fix them.

Do you think these might be fixable, or shall I just archive these games?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
18Uruguay pins PR that will require some games to be pinned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants