-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System18: Remove discarded trains from the game #11275
Conversation
Sorry, this is not the correct way to fix this. Take a look at the variable DISCARDED_TRAINS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look at the variable defined in the Game base class: DISCARDED_TRAINS
This just needs to be changed in the map method map_*_constants
@roseundy sorry did not find this and found 1822 implementation instead. |
We are still archiving System18 games, not pinning them. |
The game 182070 fixture file for System18 includes buying a previously discarded train at action 258. PR tobymao#11275 has changed it so that discarded trains are removed from the game, so there is no longer a train to buy, breaking this fixture.
Fixes #11264
Before clicking "Create"
master
pins
orarchive_alpha_games
label if this change will break existing gamesdocker compose exec rack rubocop -a
docker compose exec rack rake
May require pins if in any game discarded train was bought