Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disconnect infinite recursion and crash #9

Open
nfranke opened this issue Apr 19, 2018 · 0 comments
Open

Disconnect infinite recursion and crash #9

nfranke opened this issue Apr 19, 2018 · 0 comments

Comments

@nfranke
Copy link

nfranke commented Apr 19, 2018

If the remote side closes the TCP connection (e.g. server is shut down), this library will try to infinitely recurse sending the unregister message. That fails, so it calls disconnect() again, which tries to unregister, which fails and calls disconnect() again, etc.

disconnect() should likely set a variable that it's disconnecting and if set, just return.

nfranke pushed a commit to nfranke/vertx-swift-eventbus that referenced this issue Apr 20, 2018
If the remote side closes the TCP connection (e.g. server is shut down), this library will try to infinitely recurse sending the unregister message. That fails, so it calls disconnect() again, which tries to unregister, which fails and calls disconnect() again, etc.

disconnect() should likely set a variable that it's disconnecting and if set, just return.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant