Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PBC_flag to take coordinate names #345

Open
w-k-jones opened this issue Oct 2, 2023 · 1 comment
Open

Allow PBC_flag to take coordinate names #345

w-k-jones opened this issue Oct 2, 2023 · 1 comment
Labels
enhancement Addition of new features, or improved functionality of existing features
Milestone

Comments

@w-k-jones
Copy link
Member

With the shift to xarray, it would be nice to change PBC_flag from accepting hdim_1, hdim_2 to also accepting the xarray dimension names (e.g. latitude, longitude). Allowing min_h1, max_h1 etc. in coordinate variables rather than array indexes could also be added with this.

@w-k-jones w-k-jones added the enhancement Addition of new features, or improved functionality of existing features label Oct 2, 2023
@w-k-jones w-k-jones added this to the Version 1.6 milestone Oct 2, 2023
@freemansw1
Copy link
Member

Yes, this is a good idea, although we will need to (or we should, at least) address the fact that we don't currently have an in-built hdim_1/hdim_2 to dimension/coordinate mapping. That would be good to add, but doing so would likely require changes to our output data structure (xarray would allow for this though).

@fsenf fsenf modified the milestones: Version 1.6, Beyond v1.6 May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Addition of new features, or improved functionality of existing features
Projects
None yet
Development

No branches or pull requests

3 participants