Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the workspace_builder to plugin hooks instead of the tmux session #871

Open
hl037 opened this issue Mar 8, 2023 · 0 comments
Open

Comments

@hl037
Copy link

hl037 commented Mar 8, 2023

First of all, thank you for this app that changed my life with tmux !

In the current plugin system, it seems impossible to access the session configuration (from yaml or json).
Is there a specific reason the workspace is not passed in the hooks ?
...This would allow to easily extend the configuration file format.

I suggest to replace the session argument with a workspace_builder argument (which already gives access to the session) in the hooks. The drawback is that it's a breaking change. Here are some ways to overcome it:

  • Duplicate the hooks
    • Have the new hook call the legacy one by default
    • Call both the hooks
  • Add a new plugin class with hooks expecting the workspace builder

I can of course make a PR myself, but I need to know which way you prefer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant