Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring how macOS terminal alternatives are enabled #143

Open
fcaraujo opened this issue Aug 2, 2024 · 0 comments
Open

Refactoring how macOS terminal alternatives are enabled #143

fcaraujo opened this issue Aug 2, 2024 · 0 comments

Comments

@fcaraujo
Copy link

fcaraujo commented Aug 2, 2024

As stated in the contributing notes, I'm first bringing this issue up for discussion here before proposing any major refactoring.

It's my first time contributing, and I'm fixing issue #137 with PR #142. :)
As this is my first touch, I want to keep it short and simple while I familiarise myself with the project and we start shipping something working.

Let's cut to the chase: while adding this macOS feature, I noticed a couple of similarities between some implementations when enabling terminal alternatives such as alacritty, kitty, and hopefully WezTerm once the PR is merged. 🙏😅

As this list grows, they can probably use a single script passing the app's name as a parameter, and we don't repeat ourselves.
Although there are some minor details regarding the osx_enable.sh script we would need to think about the following:

  • current state: the template of *.plist file might get affected since the other implementations might not have the same params, approach, etc. - ideally, we should find a way to unify and use a single one;
  • docs: parts that refer to the script's name that need to be authorised;
  • also, people not familiar with it could get suspicious if we chose a weird script name;
  • name suggestions? Mine would simply be osx_start_tmux.sh and keep it simple, but of course we need to consider Terminal and iTerm and any other variances.

In the near future when I have some time available, I will start a draft PR proposing some stuff, linking this issue.
I am looking forward to hearing back from the maintainers. 🤙

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant