Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Redaction Logic to Use Notarized Transcript #97

Closed
heeckhau opened this issue Sep 11, 2024 · 1 comment · Fixed by #113
Closed

Fix Redaction Logic to Use Notarized Transcript #97

heeckhau opened this issue Sep 11, 2024 · 1 comment · Fixed by #113

Comments

@heeckhau
Copy link
Member

heeckhau commented Sep 11, 2024

When implementing the getSecretResponse function to redact the response in a browser extension plugin, the current implementation performs a regular web request replay (without TLSNotary) and uses the result for redactions. However, this replayed response is not always identical to the original notarized response, leading to incorrect or inaccurate redactions.

To resolve this issue, we need to ensure that the actual notarized transcript, which the Prover has in plaintext, is used for redactions instead of relying on the result of a replayed request.

@heeckhau
Copy link
Member Author

#113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant