-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AWS Native #25
Comments
This would just be updating the list of allowed resources, how did you generate/make the list? |
@druskus20 the Python package uses some inner details of the Pulumi provider packages to get a list of all resources and the corresponding classes, and introspection to determine if the resource is taggable (supports the Support of AWS Native is twofold:
I’ll delve into it deeper soon. |
I've implemented something like this in Typescript. It is a draft and note that neither my knowledge of typescript, or pulumi is great, so excuse the code quality.
I link it here in case it is of any help: https://gist.github.com/druskus20/e3a6cfee05e4c6654b0f70b2cd6989bf |
@druskus20 cool, thanks for the link, I'll have a look. I already experimented a bit with the Pulumi AWS Native package but in the end wasn't sure if it really makes sense to integrate it in this library. But I'll definitely take another stab into it. |
I digged deeper again and remember where the main problem was – the tests. The library uses transforms for tagging the resources which do not support unit tests using Pulumi mocks. I thus switched to integration tests using LocalStack (which IMHO is better for tests anyway). However, LocalStack doesn't seem to support Cloud Control API which Pulumi AWS Native uses. I'm very reluctant to release anything without a proper test coverage so we'll have to wait I guess. |
@tlinhart Sounds sensible. Good to know too. |
Add support for tagging resources from AWS Native package.
The text was updated successfully, but these errors were encountered: