Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] CSS is broken on the tags pages #154

Open
onnyyonn opened this issue May 31, 2022 · 3 comments
Open

[Bug] CSS is broken on the tags pages #154

onnyyonn opened this issue May 31, 2022 · 3 comments
Labels
bug Something isn't working pagevar

Comments

@onnyyonn
Copy link

The tag pages don't inherit the styles properly.

For example https://tlienart.github.io/FranklinTemplates.jl/templates/hyde/tag/syntax/

Suggested fix:
Change the line from <div class="{{div_content}}"> to <div class="franklin-content"> in _layout/tag.html.

@tlienart
Copy link
Owner

thanks for reporting, {{div_content}} by default inserts franklin-content so I need to investigate why that wasn't the case for you.

Would you mind pointing me to a commit before you applied your resolving fix so I can experiment with hit?

@onnyyonn
Copy link
Author

Thanks for your response. I don't have a commit to point you to yet, because I was trying it locally. But if needed, I can create a dummy repo.

But I am wondering, are they working as expected in your own repo? For example https://tlienart.github.io/FranklinTemplates.jl/templates/hyde/tag/syntax/ . I am seeing this page broken, as shown in the screenshot.

Screenshot_20220531_043550

@tlienart
Copy link
Owner

Thanks, actually that link was all I needed to look at, I should have looked at your first comment properly.

So here the problem is that the {{div_content}} is not properly filled, I'll look into it. Thanks (and indeed now your fix makes sense).

@tlienart tlienart added bug Something isn't working pagevar labels May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pagevar
Projects
None yet
Development

No branches or pull requests

2 participants